Load balancer rule #25
Conversation
| "frontend_ip_configuration_name": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| }, |
There was a problem hiding this comment.
Could we get a NoZeroValues here?
| Type: schema.TypeInt, | ||
| Optional: true, | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
Could we get some validation here: validation.IntBetween(4,30)
| d.Set("frontend_port", config.LoadBalancingRulePropertiesFormat.FrontendPort) | ||
| d.Set("backend_port", config.LoadBalancingRulePropertiesFormat.BackendPort) | ||
|
|
||
| if config.LoadBalancingRulePropertiesFormat.EnableFloatingIP != nil { |
There was a problem hiding this comment.
Could we break this out into a block? ie:
if properties := config.LoadBalancingRulePropertiesFormat; properties != nil {
d.Set("protocol", properties.Protocol)
...
}| LoadBalancingRulePropertiesFormat: &properties, | ||
| } | ||
|
|
||
| return &lbRule, nil |
There was a problem hiding this comment.
could we change this to:
return &network.LoadBalancingRule{
Name: utils.String(d.Get("name").(string)),
LoadBalancingRulePropertiesFormat: &properties,
}, nil| ID: &v, | ||
| } | ||
|
|
||
| properties.Probe = &pid |
There was a problem hiding this comment.
Could we change this to:
properties.Probe = &network.SubResource{
ID: &v,
}| ID: &v, | ||
| } | ||
|
|
||
| properties.BackendAddressPool = &beAP |
There was a problem hiding this comment.
And here:
properties.FrontendIPConfiguration = &network.SubResource{
ID: rule.ID,
}Instead of creating a variable and then setting it
|
Thank you for these updates @thetonymaster, LGTM now 👍 |
|
Tests pass: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
No description provided.